Port changes from vue ecosystem ci #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Haoqun Jiang <[email protected]>
So that maintainers can get one more email notification when the CI is done. Co-Authored-By: Haoqun Jiang <[email protected]>
|
nice! minor question about stability: could this lead to a result not being posted if delete message fails? might be worth adding the new comment first and then deleting the first one. Also if more comments have been added in-between, the bot comment is not going to be directly below the trigger comment anymore. Is there a way to tag that comment ? |
I think yes. I swapped that 👍
I added the commit ref to the result comment. (example: sapphi-red/vite#3 (comment)) |
dominikg
approved these changes
Oct 20, 2023
|
whoohoo, thanks!!! |
danielroe
pushed a commit
to nuxt/ecosystem-ci
that referenced
this pull request
Oct 30, 2023
* feat: add a comparison column to the PR comment Co-Authored-By: Haoqun Jiang <[email protected]> * feat: updateComment -> deleteComment + createComment So that maintainers can get one more email notification when the CI is done. Co-Authored-By: Haoqun Jiang <[email protected]> * feat: swap delete comment and create comment * feat: show ref the CI ran on * fix: fix ref link * fix: set working-directory * fix: set working-directory * feat: change ref link --------- Co-authored-by: Haoqun Jiang <[email protected]>
lilpoozie2005
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported some changes from https://github.com/vuejs/ecosystem-ci which would be useful for us