Skip to content

Add solid-router to vite-ecosystem-ci#346

Closed
birkskyum wants to merge 1 commit into
vitejs:mainfrom
birkskyum:add-solid-router
Closed

Add solid-router to vite-ecosystem-ci#346
birkskyum wants to merge 1 commit into
vitejs:mainfrom
birkskyum:add-solid-router

Conversation

@birkskyum
Copy link
Copy Markdown
Contributor

@birkskyum birkskyum commented Dec 18, 2024

This add the solid-router test suite to the vite-ecosystem-ci.

It introduces to the vite-ecosystem-ci some amount of coverage for both @solidjs/router and vite-plugin-solid.
It doesn't cover the solid-start repo / vinxi repo, which currently handles the file-based routing and nitro integration.

The terminal output from this suite is:

 ✓ test/utils.spec.ts  (71 tests) 12ms
 ✓ test/route.spec.ts  (28 tests) 9ms
 ✓ test/integration.spec.ts  (7 tests) 7ms
 ✓ test/router.spec.ts  (24 tests) 75ms

 Test Files  5 passed (5)
      Tests  131 passed (131)
   Start at  18:40:31
   Duration  1.16s (transform 449ms, setup 0ms, collect 1.12s, tests 105ms, environment 1.88s, prepare 339ms)

@dominikg
Copy link
Copy Markdown
Collaborator

dominikg commented Jan 1, 2025

Thank you for this. I have some questions regarding coverage of vite code in this PR. Skimming the tests in the solid router repo it looks like unit tests mostly, where vite is not being called at all. For vite-ecosystem-ci to be efficient, we would like to have test suites that include calls to vite api, eg e2e tests running vite dev or vite build with a framework plugin or code that calls vites directly exported api.

Unrelated tests that are not influenced by the local vite version should be excluded, eg by creating a separate test:vite-ecosystem-ci script that filters your tests for these.

@patak-cat
Copy link
Copy Markdown
Member

Discussed with @birkskyum about this PR, and we decided to close it and add later on Solid Start once they are ready.

@patak-cat patak-cat closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants