feat: add filter #470
feat: add filter #470
Conversation
sapphi-red
added
p3-significant 🔨
| : undefined, | ||
| resolveId: { | ||
| filter: { id: exactRegex(runtimePublicPath) }, | ||
| handler: (id) => (id === runtimePublicPath ? id : undefined), |
There was a problem hiding this comment.
We still need to keep the if statements to keep the compat for Vite older than v6.3.
| id: { | ||
| include: ensureArray(include).map(matchWithQuery), | ||
| exclude: [ | ||
| ...(exclude ? ensureArray(exclude).map(matchWithQuery) : []), | ||
| /\/node_modules\//, | ||
| ], |
There was a problem hiding this comment.
This filter conversion and the two utils feels a bit tricky IMO.
Could this be upstream into the Vite createFilter function so that it can be reused by other plugins?
There was a problem hiding this comment.
If we add a util function to Vite, we need to bump the required peer dep in this plugin (and the other plugins that wants to use that) which is a breaking change. I think if we do that we probably should add it to a separate package.
I'll consider if we can have @rolldown/pluginutils (since I sent a PR to @rollup/pluginutils that adds some utils functions and it's taking some time to be merged).
There was a problem hiding this comment.
This could be added and then we could do import * as Vite from 'vite' and check for the export name existence so that people using the latest version have the speedup (which is expecting for people running rolldown vite)
| skipFastRefresh && | ||
| isProduction |
There was a problem hiding this comment.
isProduction implies skipFastRefresh for now so we can skip the second check but it doesn't hurt so up to you
Description
Adds
filterso that it makes these plugin performant when used in rolldown-vite.