Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): re-resolve script after type dep changed #446

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 19, 2024

Description

close #423

use resolveScript instead of getResolvedScript to compileScript if cache is not found because the script cache will be removed when the imported type is changed.

for (const file of affectedComponents) {
invalidateScript(file)
const mods = moduleGraph.getModulesByFile(file)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

pkg-pr-new bot commented Sep 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@vitejs/plugin-vue@446
pnpm add https://pkg.pr.new/@vitejs/plugin-vue-jsx@446

commit: c3d1ca0

@edison1105 edison1105 marked this pull request as draft September 19, 2024 10:44
@edison1105 edison1105 changed the title fix(hmr): always use main module for vue sfc fix(hmr): re-resolve script after type dep changed Sep 19, 2024
@edison1105 edison1105 marked this pull request as ready for review September 19, 2024 13:30
@ccf-zeno
Copy link

ccf-zeno commented Sep 29, 2024

什么时候能合入啊,急得不行,这个太影响使用了 @sxzz

@sxzz
Copy link
Member

sxzz commented Sep 29, 2024

Then why not try pkg-pr-new? #446 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A error [plugin:vite:vue-jsx] unknown: Unexpected token occurs during hot reload.
3 participants