feat(css): support internal Sass/SCSS in HTML(#17672) #17816
+38
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielnelson09
changed the title
danielnelson09
changed the title
4 tasks
bluwy
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Overall the implementation looks great! I want to confirm with others if we want to support lang as the detection attribute here first, since the attribute is originally for locales not preprocessors. I don't think it's a big problem though if we follow precedence from vue, svelte, and astro.
added 2 commits
August 6, 2024 21:52
bluwy
reviewed
Aug 7, 2024
Comment on lines
-94
to
+103
| type: 'js' | 'css', | ||
| type: | ||
| | 'js' | ||
| | 'css' | ||
| | 'less' | ||
| | 'sass' | ||
| | 'scss' | ||
| | 'styl' | ||
| | 'stylus' | ||
| | 'pcss' | ||
| | 'postcss', |
|
Something I just realized is that VSCode (not sure about other IDEs) don't highlight scss/stylus/etc syntax in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have added support for internal css preprocessor as requested in #17672