-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: buildless ecosystem ci #18525
Open
Aslemammad
wants to merge
57
commits into
vitejs:main
Choose a base branch
from
Aslemammad:feat/buildless-ecosystem-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: buildless ecosystem ci #18525
+157
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ecosystem-ci run |
Co-authored-by: Dominik G. <[email protected]>
commit: |
As far as I know this tests the previous version of vite-ecosystem-ci
rather than the new one.
Which makes it requires a merge.
…On Tue, 5 Nov 2024, 13:43 vite-ecosystem-ci[bot], ***@***.***> wrote:
⏳ Triggered ecosystem CI: Open
<https://github.com//vitejs/vite-ecosystem-ci/actions/runs/11681487209>
—
Reply to this email directly, view it on GitHub
<#18525 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBMICDQVZRRLA6YQFS6JPLZ7CHMDAVCNFSM6AAAAABQ5A7JXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJWGY4TMNBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
📝 Ran ecosystem CI on
✅ analogjs, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, vite-plugin-pwa, vite-plugin-react-swc, vite-setup-catalogue, vitepress, vuepress |
sapphi-red
reviewed
Nov 6, 2024
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
sapphi-red
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me 👍
gerick23
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the --commit option in vite-ecosystem-ci, we can leverage the already built versions of vite in pkg.pr.new!
Here, after sending the ecosystem comment, we'll check if there's an already built version, if not, we'll try triggering a build. The 🚀 reaction is a sign that the build is happening and we should wait until it's done.
After that, the normal process continues.