Conversation
|
Quite a milestone to surpass the threshold! This looks good to me, thanks @LuLaValva! I think it is a good idea as you suggest to wait for the Marko v6 release. Do you have an ETA for it? |
|
Thanks for the quick review @patak-dev! We're not certain of the ETA yet, but we're hoping for a stable release in the next few months. I'll update this branch and ping again once we've published the major version. |
|
Good luck with the release! Looking forward to Marko being in create-vite 🎉 |
|
Alright, we're finally out of the alpha releases @patak-dev! I think this should be good to merge now, hopefully we'll be getting a little more loud about the beta release in the coming weeks 🤫 |
|
@LuLaValva we have been discussing lately with the team the best way to include frameworks like Marko in create-vite where the bare bones templates go against their recommended best practices. For Vue, Svelte, etc, a simple SPA is a common way to build production apps. So the templates are too minimal for a strong production starter recommendation (people should use create-vue for example), but they still work fine as a simplistic starter. We are discussing with the Ember folks about their starters, and recommending that we only include an option to jump to their create-ember cli and avoid the templates in create-vite. We merged simple templates for qwik a few years ago, but they also go against their framework recommendations and we're thinking about proposing the same to them and remove the simple templates. To us, these may end up confusing users pushing them away from the framework happy path. Given that in the readme you are clarifying that the added templates in the PR is not how you recommend building marko app, we are in the same boat here. What do you think about simplifying the PR removing the JavaScript and TypeScript options, and nudging Marko users to use the create marko CLI by only including that option too? |
|
That's smart, thanks for the detailed explanation @patak-dev! I've removed the basic examples, looks like a much easier review 😁 |
packages/create-vite/src/index.ts
Outdated
| name: 'marko-run', | ||
| display: 'Marko Run ↗', | ||
| color: magenta, | ||
| customCommand: 'npm create marko@latest -- --name TARGET_DIR', |
There was a problem hiding this comment.
It seems we have the same problem with #19573 (comment) here.
Merging main branch and updating this to
| customCommand: 'npm create marko@latest -- --name TARGET_DIR', | |
| customCommand: 'npm create -- marko@latest --name TARGET_DIR', |
should fix the problem.
There was a problem hiding this comment.
Oh! Good to know, thanks @sapphi-red. I added another commit that fixes this.
Co-authored-by: patak-dev <matias.capeletto@gmail.com>
Changes
create-vitemarkoandmarko-tsexamplesConcerns / Discussion Items
promptsselect doesn't show all options at once anymore 🙈tsconfig.node.jsonspecifically forvite.config.ts. We aligned with Lit and moved to a singletsconfig.jsonfor the entire project"^6.0.0-next.3.22"), so there are known bugs and updates will be frequent. It might make sense to hold off on merging this until we publish^6.0.0