Skip to content

feat(create-vite): add Marko#19257

Merged
patak-cat merged 7 commits intovitejs:mainfrom
LuLaValva:fork/create-vite-marko
Apr 28, 2025
Merged

feat(create-vite): add Marko#19257
patak-cat merged 7 commits intovitejs:mainfrom
LuLaValva:fork/create-vite-marko

Conversation

@LuLaValva
Copy link
Contributor

Changes

  • Add Marko to the list of frameworks in create-vite
  • Create marko and marko-ts examples

Concerns / Discussion Items

  • We crossed a threshold, and the prompts select doesn't show all options at once anymore 🙈
    image
  • Most of the other starters have a tsconfig.node.json specifically for vite.config.ts. We aligned with Lit and moved to a single tsconfig.json for the entire project
  • Right now the examples are using a Marko 6 prerelease version ("^6.0.0-next.3.22"), so there are known bugs and updates will be frequent. It might make sense to hold off on merging this until we publish ^6.0.0

@patak-cat
Copy link
Member

Quite a milestone to surpass the threshold! This looks good to me, thanks @LuLaValva! I think it is a good idea as you suggest to wait for the Marko v6 release. Do you have an ETA for it?

@LuLaValva
Copy link
Contributor Author

Thanks for the quick review @patak-dev! We're not certain of the ETA yet, but we're hoping for a stable release in the next few months. I'll update this branch and ping again once we've published the major version.

@patak-cat
Copy link
Member

Good luck with the release! Looking forward to Marko being in create-vite 🎉

@patak-cat patak-cat added the feat: create-vite create-vite package label Jan 21, 2025
@LuLaValva
Copy link
Contributor Author

Alright, we're finally out of the alpha releases @patak-dev! I think this should be good to merge now, hopefully we'll be getting a little more loud about the beta release in the coming weeks 🤫

@patak-cat
Copy link
Member

@LuLaValva we have been discussing lately with the team the best way to include frameworks like Marko in create-vite where the bare bones templates go against their recommended best practices. For Vue, Svelte, etc, a simple SPA is a common way to build production apps. So the templates are too minimal for a strong production starter recommendation (people should use create-vue for example), but they still work fine as a simplistic starter.

We are discussing with the Ember folks about their starters, and recommending that we only include an option to jump to their create-ember cli and avoid the templates in create-vite. We merged simple templates for qwik a few years ago, but they also go against their framework recommendations and we're thinking about proposing the same to them and remove the simple templates. To us, these may end up confusing users pushing them away from the framework happy path.

Given that in the readme you are clarifying that the added templates in the PR is not how you recommend building marko app, we are in the same boat here. What do you think about simplifying the PR removing the JavaScript and TypeScript options, and nudging Marko users to use the create marko CLI by only including that option too?

@LuLaValva
Copy link
Contributor Author

That's smart, thanks for the detailed explanation @patak-dev! I've removed the basic examples, looks like a much easier review 😁

patak-cat
patak-cat previously approved these changes Apr 24, 2025
name: 'marko-run',
display: 'Marko Run ↗',
color: magenta,
customCommand: 'npm create marko@latest -- --name TARGET_DIR',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we have the same problem with #19573 (comment) here.
Merging main branch and updating this to

Suggested change
customCommand: 'npm create marko@latest -- --name TARGET_DIR',
customCommand: 'npm create -- marko@latest --name TARGET_DIR',

should fix the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Good to know, thanks @sapphi-red. I added another commit that fixes this.

@patak-cat patak-cat merged commit 171e856 into vitejs:main Apr 28, 2025
15 checks passed
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Co-authored-by: patak-dev <matias.capeletto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: create-vite create-vite package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(create-vite): Add Marko

3 participants