Skip to content

feat(create-vite): add Marko #19257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 7 commits into from
Apr 28, 2025
Merged

feat(create-vite): add Marko #19257

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1737ed4
feat(create-vite): add Marko
LuLaValva Jan 21, 2025
9af4cdf
feat(create-vite): make SPA examples for Marko
LuLaValva Jan 21, 2025
6add554
chore: format
patak-cat Jan 21, 2025
84b445a
chore: update marko
LuLaValva Apr 15, 2025
0833beb
feat: remove SPA demo apps; only link Marko Run
LuLaValva Apr 21, 2025
7ef2452
fix: use latest and TARGET_DIR
LuLaValva Apr 22, 2025
fa3e4f0
fix: pnpm and bun
LuLaValva Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/create-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,19 @@ const FRAMEWORKS: Framework[] = [
},
],
},
{
name: 'marko',
display: 'Marko',
color: magenta,
variants: [
{
name: 'marko-run',
display: 'Marko Run ↗',
color: magenta,
customCommand: 'npm create marko@latest -- --name TARGET_DIR',
Copy link
Member

@sapphi-red sapphi-red Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we have the same problem with #19573 (comment) here.
Merging main branch and updating this to

Suggested change
customCommand: 'npm create marko@latest -- --name TARGET_DIR',
customCommand: 'npm create -- marko@latest --name TARGET_DIR',

should fix the problem.

Copy link
Contributor Author

@LuLaValva LuLaValva Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Good to know, thanks @sapphi-red. I added another commit that fixes this.

},
],
},
{
name: 'others',
display: 'Others',
Expand Down
Loading