perf(css): avoid constructing renderedModules#19775
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Apr 10, 2025
Merged
Conversation
sapphi-red
added
the
p2-nice-to-have
This was referenced Apr 2, 2025
Member
Author
|
/ecosystem-ci run |
commit: |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
|
📝 Ran ecosystem CI on
✅ ladle, analogjs, nuxt, astro, rakkas, quasar, marko, histoire, previewjs, react-router, qwik, unocss, vite-plugin-pwa, vitepress, vite-plugin-react-swc, sveltekit, vite-setup-catalogue, vite-plugin-vue, vitest, vite-plugin-cloudflare, vite-plugin-svelte, vuepress |
hi-ogawa
approved these changes
Apr 10, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous code collected all modules to an object for each chunk. It is inefficient because only some modules are actually accessed, especially when the project is large. It somehow does not cause performance problems with normal Vite, but it was degrading performance with Rolldown-Vite.
This makes the code to avoid creating the big object.
refs #19678