fix(browser): encode iframeId in tester iframe URL [backport to v4] - #10955
Merged
Conversation
sheremet-va
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10521 to
v4.createTestIframebuilds the tester iframe URL by interpolating the test-file path (iframeId) into the query string without encoding. A+in the path is decoded back as a space, so the spec no longer matches a real file, the iframe never runs the test, and browser mode hangs at0 passedwith no error. Encode the value withencodeURIComponent; it is read back with standard URL decoding (URLSearchParams.get).Clean cherry-pick of c8bf19f apart from one context-only conflict in
orchestrator.ts(const config = getConfig()exists only onmain). Includes the regression test from the original PR.