fix(browser): exit gracefully when the browser disconnects during cancellation - #10962
Open
sheremet-va wants to merge 2 commits into
Open
fix(browser): exit gracefully when the browser disconnects during cancellation#10962sheremet-va wants to merge 2 commits into
sheremet-va wants to merge 2 commits into
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The graceful-cancel branch in the browser pool checked
but the error created by the websocket close handler has always carried the
[vitest]prefix. Both sides were introduced in the same commit (#7665), so the branch has never matched: cancelling a run (for example with Ctrl+C) while the browser connection drops reportedFailed to run the test ...as an unhandled error instead of exiting quietly.Instead of fixing the string, the close handler now rejects pending calls with a dedicated
BrowserConnectionError(exported fromvitest/node), and the pool matches on the type. The regression test cancels the run from a browser command and then crashes the renderer, so the pendingcreateTesterscall rejects whileisCancellingis set; it fails onmainwith the unhandled error and passes with the fix.