fix: own the post-restart rerun, keep process.exit disabled in workers - #10963
Merged
Conversation
process.exit disabled in workers
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rerun that
startVitestschedules after a watch-mode server restart ran as a floating promise with no error handling. Anything failing inside it became an unhandled rejection in whatever process hosted the Vitest instance. This was the source of most of the recent CI flakes: our meta-tests run Vitest inside sharedisolate: falseforks workers, where the realprocess.exitwas restored after the first test file, so a late rejection could escalate into the whole worker being killed mid-run ("Worker forks emitted error").The restart now awaits its rerun and reports failures the same way the initial run does, and workers keep
process.exitdisabled until teardown, so a stray exit call fails loudly with the test file in the message instead of taking down the process.