Skip to content

chore: externalize tinyglobby#7949

Closed
benmccann wants to merge 1 commit intovitest-dev:mainfrom
benmccann:tinyglobby-external
Closed

chore: externalize tinyglobby#7949
benmccann wants to merge 1 commit intovitest-dev:mainfrom
benmccann:tinyglobby-external

Conversation

@benmccann
Copy link
Contributor

Description

Vite doesn't bundle it: https://npmgraph.js.org/?q=vite

By externalizing it here, it can be deduped ultimately resulting in a smaller bundle and install size

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b2380a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/681d7bfca82a550008caf7ca
😎 Deploy Preview https://deploy-preview-7949--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa
Copy link
Contributor

hi-ogawa commented May 9, 2025

I think we already did this #7864. Do you see it's still bundled in latest vitest?

@sheremet-va
Copy link
Member

I think we already did this #7864. Do you see it's still bundled in latest vitest?

Yes, it's already external with Object.keys(pkg.dependencies), no need to duplicate it

@sheremet-va sheremet-va closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants