-
Notifications
You must be signed in to change notification settings - Fork 6
Change deriving endpoint #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
Missing a Javadoc comment.
Line 6 in bb2413a
| public BadServerResponseException() { |
Missing a Javadoc comment.
Line 11 in bb2413a
| public BadServerResponseException(String msg) { |
Missing a Javadoc comment.
Line 16 in bb2413a
| public BadServerResponseException(String msg, int statusCode) { |
Missing a Javadoc comment.
Line 21 in bb2413a
| public BadServerResponseException(String msg, Throwable cause) { |
Missing a Javadoc comment.
Line 26 in bb2413a
| public BadServerResponseException(Throwable cause) { |
Missing a Javadoc comment.
Line 4 in bb2413a
| public BadClientResponseException() { |
Missing a Javadoc comment.
Line 8 in bb2413a
| public BadClientResponseException(String msg) { |
Missing a Javadoc comment.
Line 12 in bb2413a
| public BadClientResponseException(String msg, Throwable cause) { |
Missing a Javadoc comment.
Line 16 in bb2413a
| public BadClientResponseException(Throwable cause) { |
Missing a Javadoc comment.
Line 27 in bb2413a
| public ChangeRecordingRemoteView(RemoteView base) { |
Missing a Javadoc comment.
Line 129 in bb2413a
| public void commitChanges(Iterable<UserInteractionBase> userInputs) { |
Missing a Javadoc comment.
Vitruv-Server/remote/src/main/java/tools/vitruv/framework/remote/client/impl/RemoteViewSelector.java
Line 26 in bb2413a
| public RemoteViewSelector( |
First sentence of Javadoc is missing an ending period.
Vitruv-Server/remote/src/main/java/tools/vitruv/framework/remote/client/impl/RemoteView.java
Line 151 in bb2413a
| /** UNSUPPORTED AT THE MOMENT!! */ |
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Line 10 in bb2413a
| public static final String CHANGE_DERIVING = "/vsum/view/derive-changes"; |
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/server/http/java/RequestHandler.java
Show resolved
Hide resolved
remote/src/main/java/tools/vitruv/framework/remote/common/apm/SingleMeasureRecordingTimer.java
Show resolved
Hide resolved
|
|
LGTM |


added the changes deriving endpoint from Yannik Schmid.