Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.builder: fix build using msvc with multiple C sources (for example programs using #flag file.c) #22377

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

crackedmind
Copy link
Member

@crackedmind crackedmind commented Oct 1, 2024

Fix #22376

@crackedmind crackedmind changed the title Fix #22376 builder: fix compiler using msvc with multiple C sources Oct 1, 2024
@crackedmind crackedmind changed the title builder: fix compiler using msvc with multiple C sources builder: fix build using msvc with multiple C sources Oct 1, 2024
@crackedmind crackedmind changed the title builder: fix build using msvc with multiple C sources builder: build using msvc with multiple C sources Oct 1, 2024
@spytheman spytheman changed the title builder: build using msvc with multiple C sources v.builder: fix build using msvc with multiple C sources (for example programs using #flag file.c) Oct 1, 2024
@spytheman
Copy link
Member

Please also add a test case in vlib/v/gen/c/testdata/ - a small .vv program, that uses
#flag file.c, having something like:

int answer() { return 42 }

then calls println(C.answer()), and a corresponding .out file to the .vv program, containing just a line with 42 .

@crackedmind
Copy link
Member Author

and how i should do this ? i need example :)

@spytheman
Copy link
Member

Only sanitized CI jobs remain, the Windows ones passed, so it is good to merge.

@spytheman spytheman merged commit 3b9651d into vlang:master Oct 1, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builder: can't compile using msvc with multiple c sources
2 participants