Add Ubi container #213
Closed
Add Ubi container #213
+58
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Build Artifacts Available |
sjmonson
requested changes
Jul 9, 2025
There was a problem hiding this comment.
@strangiato I don't really want to have two container images that do basically the same thing. Can you make you changes to the existing container image and replace the PYTHON arg with BASE_IMAGE=docker.io/python:3.13-slim. Ideally we would switch over completely to the ubi image, but we need python3.13 for our upstream bulild.
sjmonson
added a commit
to sjmonson/guidellm
that referenced
this pull request
Jul 30, 2025
sjmonson
added a commit
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
added a commit
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Samuel Monson <[email protected]>
sjmonson
added a commit
that referenced
this pull request
Jul 30, 2025
* Drop the container entrypoint script as GuideLLM has had native support for its features since #99 * Make containerfile more rebuild friendly based on #213 * Drop the ENV default scenario as it is confusing to users setting CLI args Closes: #213 --------- Signed-off-by: Samuel Monson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new UBI based containerfile as an alternative to the current docker python container.
UBI generally recommends utilizing
/opt/app-rootas the default location for installing/configuring end user application software so this PR also makes the entrypoint.sh able to utilize a GUIDELLM_BIN environment variable to allow the correct bin location to be defined in the container.