Skip to content

Conversation

sjmonson
Copy link
Collaborator

@sjmonson sjmonson commented Sep 10, 2025

Summary

Adds a python extras group for recommended packages and adds a couple optional tokenizer packages to it.

Details

  • Adds the recommended package group with tiktoken, and blobfile
  • Add default-optional-dependency-keys field for future compatibly with PEP 771 compliant tools pip is picky about the key in [project] so reverted. Since the group name is the default I'm not sure this is even necessary.

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Python package extras group called "recommended" that includes optional tokenizer packages for enhanced functionality. The change introduces optional dependencies for tiktoken and blobfile packages to support OpenAI tokenizer features.

  • Adds a "recommended" extras group with tiktoken and blobfile dependencies
  • Includes a pdm.toml configuration update for dependency management strategy

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Adds the "recommended" optional dependencies group with tiktoken and blobfile packages
pdm.toml Adds strategy configuration for dependency updates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@AlonKellner-RedHat AlonKellner-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sjmonson sjmonson merged commit a4bdbb5 into main Sep 12, 2025
17 checks passed
@sjmonson sjmonson deleted the feat/optional_deps branch September 12, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants