WA shared bias in UA #727
Merged
WA shared bias in UA #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
adobrzyn
requested review from
afierka-intel,
iboiko-habana,
kamil-kaczor,
ksmusz,
kzawora-intel,
mgawarkiewicz-intel,
michalkuligowski and
xuechendi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a workaround to address out-of-memory issues related to huge shared bias in the unified bucketing strategy by limiting the maximum shared context to a single block size instead of calculating it based on model length and available blocks.
- Temporarily caps
max_shared_ctxtoblock_sizeto prevent OOM errors - Comments out the original calculation logic for future restoration
- Adds a TODO comment indicating this is a temporary workaround
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
✅ CI PassedAll checks passed successfully against the following vllm commit: |
kzawora-intel
approved these changes
Jan 7, 2026
jinyouzhi
pushed a commit
to jinyouzhi/vllm-gaudi
that referenced
this pull request
Jan 14, 2026
Signed-off-by: Agata Dobrzyniewicz <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]> Signed-off-by: Jin, Youzhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.