-
Notifications
You must be signed in to change notification settings - Fork 188
[Feature][WIP] Basic version of supporting streaming output #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Gaohan123
wants to merge
7
commits into
vllm-project:main
Choose a base branch
from
Gaohan123:stream_output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,037
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaohan123 <[email protected]>
Signed-off-by: Gaohan123 <[email protected]>
Signed-off-by: Gaohan123 <[email protected]>
Signed-off-by: Gaohan123 <[email protected]>
62 tasks
|
@Gaohan123 @hsliuustc0106 Will the 1230 release #165 include support for returning audio data when stream: true is enabled #373 ? |
18 tasks
5 tasks
|
This feature is really needed! Even just streaming for text output would be great. |
Signed-off-by: Gaohan123 <[email protected]>
1 task
Signed-off-by: Gaohan123 <[email protected]>
Signed-off-by: Gaohan123 <[email protected]>
Collaborator
|
for this feature, do we support text streaming for the first stage and leave the audio streaming for the follow-up PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR supports basic straming output for both offline and online. For text, it can output token by token or fixed chunk size. For audio output, it depends on later feature of chunked async pipeline across multiple stages.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)