Skip to content

Conversation

@iwzbi
Copy link

@iwzbi iwzbi commented Dec 23, 2025

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Support stable diffusion3 #311

Test Plan

Test Result

image image image image image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@iwzbi iwzbi requested a review from hsliuustc0106 as a code owner December 23, 2025 13:08
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 53 to 56
"longcat_image",
"pipeline_longcat_image_edit",
"LongcatImageEditPipeline",
"StableDiffusion3Pipeline": (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Fix malformed diffusion model registry entry

The _DIFFUSION_MODELS dictionary is syntactically invalid because the LongCatImageEditPipeline entry is missing its closing parenthesis and trailing comma before the StableDiffusion3Pipeline entry, leaving the file unparsable. Importing vllm_omni.diffusion.registry will raise a SyntaxError, preventing any diffusion model (including the new SD3 pipeline) from being registered or loaded.

Useful? React with 👍 / 👎.

iwzbi and others added 4 commits December 23, 2025 22:03
Signed-off-by: iwzbi <[email protected]>
go
Signed-off-by: iwzbi <[email protected]>
go
Signed-off-by: iwzbi <[email protected]>
go
Signed-off-by: iwzbi <[email protected]>
go
Signed-off-by: iwzbi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant