Skip to content

[Misc] Support more collective_rpc return types #21845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025

Conversation

njhill
Copy link
Member

@njhill njhill commented Jul 29, 2025

Because of how msgspec is used for the front-end <-> engine IPC message encoding, only "simple" native python data types/structures will correctly roundtrip when returned in the UtilityOutput struct from the call_utility(_async) method.

This change allows arbitrary msgspec-supported types to be returned, as well as tensors/numpy-arrays which will use the existing zero-copy optimizations. It also checks for lists of such types. Such cases will require VLLM_ALLOW_INSECURE_SERIALIZATION to be set since arbitrary types are materialized from strings when decoding.

This in particular is needed for #18465.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Jul 29, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for more complex return types from collective_rpc by introducing a UtilityResult wrapper and custom serialization/deserialization logic. This allows msgspec to handle types it doesn't support natively by encoding type information alongside the data.

The overall approach is sound. I've identified one potential issue in the serialization logic where using cls is not list is too specific and could lead to incorrect behavior with subclasses of list. I've suggested a more robust implementation using isinstance.

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill marked this pull request as ready for review July 30, 2025 08:57
@njhill njhill requested a review from DarkLight1337 July 30, 2025 09:05
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 30, 2025 10:06
@DarkLight1337
Copy link
Member

V1 test passes, let's merge this

@vllm-bot vllm-bot merged commit 56bd537 into vllm-project:main Jul 30, 2025
72 of 78 checks passed
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants