Skip to content

[Docs] Update docker.md with HF_TOKEN, new model, and podman fix #21856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jul 29, 2025

Previously if you ran the podman command, it would fail because it doesn't default to dockerhub as a registry

Error: short-name "vllm/vllm-openai:latest" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"

But there are other issues like gpu passthrough.

@mgoin mgoin requested a review from hmellor as a code owner July 29, 2025 17:41
@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 29, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Docker documentation by fixing an issue with the podman command, making the Hugging Face token handling consistent, and changing the example model. While the podman fix and token handling are good improvements, I've identified a critical issue: the new example model name appears to be invalid, which would cause the documented commands to fail. My review includes suggestions to use a valid model to ensure the examples are runnable for users.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

There is also #19236 which attempts to solve the registry issue, do you prefer modifying the podman command instead of modifying the Dockerfile?

@mgoin
Copy link
Member Author

mgoin commented Jul 29, 2025

I think we have to do both since the change here is modifying the command to fetch the prebuilt image from dockerhub, and the change you linked is just to fix podman building the image from source

@vllm-bot vllm-bot merged commit fb58e3a into main Jul 30, 2025
18 checks passed
@vllm-bot vllm-bot deleted the docker-md-podman-fix branch July 30, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation force-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants