On the client side, handle a server shutdown. #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a client that is reading a stream from the server. When the server shuts down, the client hangs, basically because it is waiting here:
Making sure that when we get
connection_lost
from the asyncio protocol that all the streams are closed fixes it for me (this will set the ready_event in the buffer).In addition, I had to make sure that the
async with api.Method.open() as stream:
context manager doesn't hang in__aexit__
after that trying to read the trailing metadata.What else is needed?