Implement connection checks using PING frame. Task #62 #96
Conversation
grpclib/protocol.py
Outdated
| self._ping_handle = None | ||
| return | ||
| current_time = time.monotonic() | ||
| time_to_next_ping = self._config._keepalive_time - ( |
There was a problem hiding this comment.
According to https://github.com/grpc/proposal/blob/master/A8-client-side-keepalive.md
Restricts clients to avoid configuring their keepalive below ten seconds
We have to limit somehow minimum time between two consequent pings
| self.connection.last_headers_received = time.monotonic() | ||
| self.connection.data_process() |
There was a problem hiding this comment.
I think that the same should be done in process_response_received and in process_trailers_received, they all are called after we receive HEADERS frame.
There was a problem hiding this comment.
Now it seems to me that the received message and headers do not interest us.
This channel argument controls the maximum number of pings that can be sent when there is no other data (data frame or header frame) to be sent
|
Squashed and merged PR into master with some fixes. Thanks! |
No description provided.