This repository was archived by the owner on Apr 25, 2022. It is now read-only.
Add bzip2 and Umineko steam release support #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
suggested changes
Jul 6, 2018
| return combine64( s.total_out_lo32, s.total_out_hi32 ); | ||
| } | ||
| inline uint64_t total_in( const bz_stream &s ) { | ||
| return combine64( s.total_in_lo32, s.total_in_hi32 ); |
| { | ||
| /* http://bzip.org/1.0.5/bzip2-manual-1.0.5.html#bzcompress-init */ | ||
|
|
||
| const std::array<int,4> levels { 9, 6, 1, 0 }; |
| const bstr &input, | ||
| const CompressionLevel = CompressionLevel::Best); | ||
|
|
||
|
|
| include_directories(${ZLIB_INCLUDE_DIR}) | ||
| link_directories(${ZLIB_LIBRARY_DIRS}) | ||
|
|
||
| find_package(BZip2 REQUIRED) |
Member
There was a problem hiding this comment.
Could you make this into optional dependency?
Member
|
Also the commit messages should be adjusted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Umineko steam releases. (nscripter/nsa; compression type 4 (Nbz)) It also fixes issue #152 as well.