-
Notifications
You must be signed in to change notification settings - Fork 2
feat(web3): decode reverts and custom errors properly #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccdcdd5 to
1907b00
Compare
20bae6e to
3c1f173
Compare
3c1f173 to
dd32266
Compare
Member
|
@cursor review |
p4u
approved these changes
Jan 12, 2026
Member
p4u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but wait for cursor review
efb8ba7 to
fe38d29
Compare
also simulates the tx before actual sending, just like production code
fe38d29 to
ea9166e
Compare
3b90e72 to
1ecce47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Improves reliability and debuggability across web3 and sequencer layers.
rpc.ParseErrorandContracts.DecodeErrorto extract revert data and decode custom errors via loaded ABIs; applied to gas estimation, simulations, andSetProcess*calls for clearer error messagesProcessRegistryABI()/others as getters; removes ad-hoc parsing and test-time ABI wiringNewEIP4844Transaction(+WithNonce)now take pre-packeddata(no ABI/method/args); updatessend-bloband process transition/results paths to pack via ABI then pass raw data; improved gas estimation error reportingrpc.RPCErrorProcessRegistryABI()and drop manual ABI setup in testsWritten by Cursor Bugbot for commit dd32266. This will update automatically on new commits. Configure here.