Skip to content

Conversation

@altergui
Copy link
Contributor

@altergui altergui commented Jan 5, 2026

Note

Improves reliability and debuggability across web3 and sequencer layers.

  • Revert/custom error decoding: Introduces rpc.ParseError and Contracts.DecodeError to extract revert data and decode custom errors via loaded ABIs; applied to gas estimation, simulations, and SetProcess* calls for clearer error messages
  • Centralized ABI management: Parses and caches contract ABIs at init; exposes ProcessRegistryABI()/others as getters; removes ad-hoc parsing and test-time ABI wiring
  • EIP-4844 tx builder refactor: NewEIP4844Transaction(+WithNonce) now take pre-packed data (no ABI/method/args); updates send-blob and process transition/results paths to pack via ABI then pass raw data; improved gas estimation error reporting
  • RPC/client tweaks: Use geth RPC types consistently; include RPC error code/data in retry errors; simulation types now use shared rpc.RPCError
  • Sequencer/tests updates: Switch simulations to ProcessRegistryABI() and drop manual ABI setup in tests

Written by Cursor Bugbot for commit dd32266. This will update automatically on new commits. Configure here.

@altergui altergui force-pushed the better-blob-tx-handling branch from ccdcdd5 to 1907b00 Compare January 6, 2026 12:09
@altergui altergui marked this pull request as ready for review January 7, 2026 08:43
@altergui altergui marked this pull request as draft January 7, 2026 08:43
@altergui altergui force-pushed the better-blob-tx-handling branch 5 times, most recently from 20bae6e to 3c1f173 Compare January 12, 2026 10:14
@altergui altergui changed the title wip preserve error data feat(web3): decode reverts and custom errors properly Jan 12, 2026
@altergui altergui marked this pull request as ready for review January 12, 2026 10:14
@altergui altergui requested a review from p4u January 12, 2026 10:14
@altergui altergui force-pushed the better-blob-tx-handling branch from 3c1f173 to dd32266 Compare January 12, 2026 11:51
@p4u
Copy link
Member

p4u commented Jan 12, 2026

@cursor review

Copy link
Member

@p4u p4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for cursor review

@altergui altergui force-pushed the better-blob-tx-handling branch 2 times, most recently from efb8ba7 to fe38d29 Compare January 13, 2026 09:12
@altergui altergui force-pushed the better-blob-tx-handling branch from fe38d29 to ea9166e Compare January 13, 2026 10:01
@altergui altergui force-pushed the better-blob-tx-handling branch from 3b90e72 to 1ecce47 Compare January 13, 2026 10:58
@altergui altergui merged commit d8c012b into main Jan 13, 2026
7 checks passed
@altergui altergui deleted the better-blob-tx-handling branch January 13, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants