Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support concurrent-podgroup-syncs #2997

Merged
merged 1 commit into from
Jul 31, 2023
Merged

support concurrent-podgroup-syncs #2997

merged 1 commit into from
Jul 31, 2023

Conversation

WulixuanS
Copy link
Contributor

A separate parameter to adjust the concurrency of pg sync
support #2996

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@WulixuanS WulixuanS force-pushed the feature/concurrent-podgroup-syncs branch from 3bda679 to e8525d0 Compare July 25, 2023 11:55
@lowang-bh
Copy link
Member

There is a param WorkerThreads to control it. Why do you add another one?

@lowang-bh
Copy link
Member

/hold

@volcano-sh-bot volcano-sh-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@WulixuanS
Copy link
Contributor Author

There is a param WorkerThreads to control it. Why do you add another one?

  1. param WorkerThreads both controls job-controller and pg-controller. Now i used volcano to schedule pod, I only want to adjust pg-controller worker number to improve pg creation rate.
  2. Each controller in K8S has independent syncs parameters to adjust, I think this is more flexible.

@lowang-bh
Copy link
Member

/hold cancel

@volcano-sh-bot volcano-sh-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@william-wang
Copy link
Member

There is a param WorkerThreads to control it. Why do you add another one?

  1. param WorkerThreads both controls job-controller and pg-controller. Now i used volcano to schedule pod, I only want to adjust pg-controller worker number to improve pg creation rate.
  2. Each controller in K8S has independent syncs parameters to adjust, I think this is more flexible.
    Would you share some testing data about improving pg create rate after adjust the worker threads?

@WulixuanS WulixuanS force-pushed the feature/concurrent-podgroup-syncs branch 4 times, most recently from ba0040f to 26d912c Compare July 27, 2023 07:26
@WulixuanS WulixuanS force-pushed the feature/concurrent-podgroup-syncs branch from 26d912c to 325e3dd Compare July 27, 2023 13:13
william-wang
william-wang approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@volcano-sh-bot volcano-sh-bot merged commit 4be3200 into volcano-sh:master Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@william-wang william-wang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WulixuanS @lowang-bh @william-wang @volcano-sh-bot