Add pdb support feature gate #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @bibibox! |
volcano-sh-bot
added
the
size/S
|
Please add some backgroud info and sign off your commit. |
bibibox
force-pushed
the
add_pdb_feature_gate
branch
2 times, most recently
from
1dbd290
to
0aa5307
Compare
done |
|
/lgtm |
|
@bibibox please update the licenses lint. |
bibibox
force-pushed
the
add_pdb_feature_gate
branch
from
0aa5307
to
45dd748
Compare
bibibox
force-pushed
the
add_pdb_feature_gate
branch
from
45dd748
to
ba809bf
Compare
Signed-off-by: Wenbo Zhang <[email protected]>
bibibox
force-pushed
the
add_pdb_feature_gate
branch
from
ba809bf
to
6127f20
Compare
william-wang
approved these changes
Feb 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3012
This PR add a feature gate for pdb resource.