Draft: add .node_version fallback #1974
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriskrycho what do you think about support I didn't want to distract you, but it's very interesting. Sorry:) |
antongolub
reviewed
Jan 10, 2025
| let project_path = manifest_file.parent()?; | ||
|
|
||
| match std::fs::read_to_string(project_path.join(".node_version")) { | ||
| Ok(version) => match Version::parse(version) { |
There was a problem hiding this comment.
How Version::parse resolves ranges?
22 > 22.0.0?
There was a problem hiding this comment.
There will be a error in the current draft. It won't be difficult to add the latest available version.
There was a problem hiding this comment.
@easymikey What needs to be done for this to be merged?
There was a problem hiding this comment.
I can implement this logic on Monday, if needed quickly. But do you know if mentainers can merge it?
|
Please make this happen! 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1973
implemented a small draft