Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PThread + CUDA support for naming resources; Make Safe 1:1 API #18

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Add PThread + CUDA support for naming resources; Make Safe 1:1 API #18

merged 8 commits into from
Mar 28, 2024

Conversation

willkill07
Copy link
Contributor

@willkill07 willkill07 commented Mar 27, 2024 •
edited
Loading

As a note: I haven't found any example online of people naming CUDA or PThread-specific resources (or even using the resource naming API at all).

  • Conditionally adds PThread resource naming support if on a unix target
  • Conditionally adds Cuda resource naming support if feature cuda is enabled
  • Conditionally adds CudaRuntime resource naming support if feature cuda_runtime is enabled
  • Adds cuda and cuda_runtime features to nvtx-sys crate

@willkill07 willkill07 force-pushed the pthread-identifier-naming branch from aeef409 to 0852717 Compare March 28, 2024 02:54
@willkill07 willkill07 changed the title Add pthread support for naming resources Add pthread + CUDA support for naming resources Mar 28, 2024
@willkill07 willkill07 changed the title Add pthread + CUDA support for naming resources Add Pthread + CUDA support for naming resources Mar 28, 2024
@willkill07 willkill07 changed the title Add Pthread + CUDA support for naming resources Add PThread + CUDA support for naming resources Mar 28, 2024
@willkill07 willkill07 marked this pull request as ready for review March 28, 2024 14:41
@willkill07 willkill07 requested a review from mbrobbel March 28, 2024 14:41
mbrobbel
mbrobbel reviewed Mar 28, 2024
View reviewed changes
@willkill07
Update crate documentation
6f136ac 
Signed-off-by: Will Killian <[email protected]>
@willkill07
add non_exhaustive
6c384a8 
Signed-off-by: Will Killian <[email protected]>
mbrobbel
mbrobbel approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore my comments if they don't make sense.

willkill07 and others added 3 commits March 28, 2024 11:27
@willkill07 @mbrobbel
Apply suggestions from code review
c4b1713 
Co-authored-by: Matthijs Brobbel <[email protected]>
@willkill07
restructure identifiers
4b250ce 
Signed-off-by: Will Killian <[email protected]>
@willkill07
Add safe API; rename types
23ef75b 
Signed-off-by: Will Killian <[email protected]>
@willkill07 willkill07 force-pushed the pthread-identifier-naming branch from 19c74c4 to 23ef75b Compare March 28, 2024 20:38
@willkill07 willkill07 changed the title Add PThread + CUDA support for naming resources Add PThread + CUDA support for naming resources; Make Safe 1:1 API. Mar 28, 2024
@willkill07 willkill07 changed the title Add PThread + CUDA support for naming resources; Make Safe 1:1 API. Add PThread + CUDA support for naming resources; Make Safe 1:1 API Mar 28, 2024
@willkill07 willkill07 merged commit f2966ae into main Mar 28, 2024
5 checks passed
@willkill07 willkill07 deleted the pthread-identifier-naming branch March 28, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrobbel mbrobbel mbrobbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willkill07 @mbrobbel