Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for sub claim, not username, when validating #310

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Check for sub claim, not username, when validating #310

wants to merge 7 commits into from

Commits on Nov 22, 2021

  1. remove ID, a vestige of the db

    @bnfinet @rhansen
    bnfinet authored and rhansen committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0ef511d View commit details
    Browse the repository at this point in the history

  2. Delete unused GoogleUser struct

    @bnfinet @rhansen
    bnfinet authored and rhansen committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2f8a037 View commit details
    Browse the repository at this point in the history

  3. Delete unused fields from AliData

    @rhansen
    rhansen committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    5b332a3 View commit details
    Browse the repository at this point in the history

  4. GitHub: Simplify User object copy

    @rhansen
    rhansen committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    bab9864 View commit details
    Browse the repository at this point in the history

  5. GitHub: Fix user info sample used for testing 

    GitHub doesn't provide username, createdon, lastupdate, or sub in the
user info JSON it returns.
    @rhansen
    rhansen committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2efe90c View commit details
    Browse the repository at this point in the history

  6. GitHub: Improve debug logging

    @bnfinet @rhansen
    bnfinet authored and rhansen committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    8298dda View commit details
    Browse the repository at this point in the history

  7. Check for sub claim, not username, when validating 

    Not all IdPs provide a `username` or `email` claim in the UserInfo
response, and many IdPs allow users to change their username or email
address.

Co-authored-by: Benjamin Foote <[email protected]>
    @rhansen @bnfinet
    rhansen and bnfinet committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    270fa9f View commit details
    Browse the repository at this point in the history