implement Select component #34
Conversation
| import { FC } from "react"; | ||
|
|
||
| export const CheckIcon: FC<IconProps> = ({ className, ...props }) => ( | ||
| <svg |
There was a problem hiding this comment.
I previously added this Icon component to try to reduce the need to define the svg in every icon, it may need to be modified to change height/width: https://github.com/voxel51/design-system/blob/develop/src/components/Icons/Icon.tsx
There was a problem hiding this comment.
yeah I had tried to use it, but it didn't seem to work correctly as a standalone icon (seems fine in the checkbox though). I didn't want to muck with the checkbox so added this one for now. Let's take another look once we have a good icon strategy
src/components/Select/Select.tsx
Outdated
| <Combobox value={value} onChange={handleChange} multiple={!exclusive}> | ||
| {/*// todo - replace with `Input` when available*/} | ||
| <ComboboxInput | ||
| displayValue={(v: string | string[] | null): string => |
There was a problem hiding this comment.
nitpick - might be nice to move this function outside the JSX just for readability
There was a problem hiding this comment.
agreed, mostly a placeholder for now but i'll clean it up with the real thing
Rationale
Implement a generic
Selectcomponent supporting uncontrolled, controlled, and multi-select variants.Changes
SelectcomponentclassNamenot being passed inStackTesting
local,
npm run test