update and refactor color management #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-nieh
approved these changes
Jan 5, 2026
Contributor
erik-nieh
left a comment
erik-nieh
left a comment
There was a problem hiding this comment.
This looks great, I will update my Radio PR to use this when merged
tom-vx51
force-pushed
the
chore/update-colors
branch
from
8610835 to
643f29e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Refactor color management to be more consistent across the components.
Primary motivation is driven by the fact that we typically deal with colors in two ways: either setting the foreground content (text/icon/etc.), or setting the background color. While we have semantics which dictate which colors should be applied to which content, we can set sensible restrictions within the components (e.g. only accepting a
TextColorenum value) while allowing for flexibility in our general color management.Changes
Testing
storybook,
npm run build && npm run test