-
Notifications
You must be signed in to change notification settings - Fork 1
[as-1069] Add asdf and pre-commit caches #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v2.15.0
Are you sure you want to change the base?
[as-1069] Add asdf and pre-commit caches #501
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughThe pull request template gains a new "Review Priority" section with three checkbox options—high, medium, and low—enabling contributors to flag their review urgency expectations during submission. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
I don't think we can use private actions in a public repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/pull_request_template.md:
- Around line 5-10: Change the "Review Priority" section to a proper heading
(e.g., "## Review Priority"), explicitly state that the markdown checkboxes do
not create GitHub labels and instruct contributors to also select the
corresponding priority label from the PR sidebar (or run the repo's labeling
command if automation exists), and add guidance to choose exactly one checkbox
(or mark "none" if not applicable) so the choices are mutually exclusive; update
the copy around the existing checkboxes to reflect this clarified workflow and
mutual-exclusivity requirement.
| <!-- Please also assign a priority label to the PR. --> | ||
| Review Priority | ||
|
|
||
| * [ ] high | ||
| * [ ] medium | ||
| * [ ] low |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the priority selection mechanism and improve formatting.
The instruction states "assign a priority label," but markdown checkboxes don't automatically create GitHub labels. Unless there's automation (not mentioned in the PR description) that reads these checkboxes and assigns actual labels, this instruction may confuse contributors.
Additionally:
- Consider formatting "Review Priority" as a heading (
## Review Priority) to match the style of "Rationale" and "Changes" - The checkboxes don't enforce mutual exclusivity—users could check multiple priorities or none
📝 Suggested improvements
-<!-- Please also assign a priority label to the PR. -->
+<!-- Please select one priority level for this PR. -->
-Review Priority
+## Review Priority
* [ ] high
* [ ] medium
* [ ] low📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <!-- Please also assign a priority label to the PR. --> | |
| Review Priority | |
| * [ ] high | |
| * [ ] medium | |
| * [ ] low | |
| <!-- Please select one priority level for this PR. --> | |
| ## Review Priority | |
| * [ ] high | |
| * [ ] medium | |
| * [ ] low |
🤖 Prompt for AI Agents
In @.github/pull_request_template.md around lines 5 - 10, Change the "Review
Priority" section to a proper heading (e.g., "## Review Priority"), explicitly
state that the markdown checkboxes do not create GitHub labels and instruct
contributors to also select the corresponding priority label from the PR sidebar
(or run the repo's labeling command if automation exists), and add guidance to
choose exactly one checkbox (or mark "none" if not applicable) so the choices
are mutually exclusive; update the copy around the existing checkboxes to
reflect this clarified workflow and mutual-exclusivity requirement.
|
Update! it looks like there's a workaround |
…cache on merge to main (to speed up installs). chore(workflows): update names of asdf-dependabot-update workflow steps. chore(pr-template): add priority to rationale. chore(workflows): replace existing usage of asdf install to use new action (with cache for speedups).
…oha-github-workflows.
48f8d11 to
d1490d2
Compare
… debug statements. Add debug statements for relative action. Add sed statement to replace repo action (generate-version-file) with relative action. Update relative path for `asdf-install-and-cache` action.
Rationale
Aloha would like to speed up our pre-commit and asdf PR checks through caches.
In https://github.com/voxel51/aloha-github-workflows/pull/52 we added two new custom actions for pre-commit and asdf to leverage GitHub caches.
Review Priority
Changes
update-asdfjob when matrix is empty ('[]')Testing