Grid caching feedback #7534
pr.yml
on: pull_request
modified-files
27s
teams
0s
Matrix: test / test-python
build
/
changes
28s
build
/
build
2m 15s
e2e
/
test-e2e
19m 44s
lint
/
eslint
49s
test
/
test-app
1m 23s
all-tests
0s
Annotations
12 errors, 20 warnings, and 1 notice
test / test-python (ubuntu-latest-m, 3.10)
TypeError: fetch failed
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Error: expect(locator).toHaveScreenshot(expected)
Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveScreenshot(expected)
Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry1/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry1/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveScreenshot(expected)
Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry2/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry2/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveScreenshot(expected)
Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry3/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry3/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- Expected an image 966px by 147px, received 966px by 171px. 34403 pixels (ratio 0.21 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups:
e2e-pw/src/oss/poms/grid/index.ts#L119
2) [chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups
Error: expect(received).toBe(expected) // Object.is equality
Expected: 8
Received: 2
at oss/poms/grid/index.ts:119
117 | .getByTestId("looker")
118 | .count();
> 119 | expect(lookersCount).toBe(n);
| ^
120 | }
121 |
122 | async isNthSampleSelected(n: number) {
at GridAsserter.isLookerCountEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:119:26)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:69:5
|
[chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups:
e2e-pw/src/oss/poms/grid/index.ts#L119
2) [chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: 8
Received: 4
at oss/poms/grid/index.ts:119
117 | .getByTestId("looker")
118 | .count();
> 119 | expect(lookersCount).toBe(n);
| ^
120 | }
121 |
122 | async isNthSampleSelected(n: number) {
at GridAsserter.isLookerCountEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:119:26)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:69:5
|
[chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups:
e2e-pw/src/oss/poms/grid/index.ts#L119
2) [chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: 8
Received: 4
at oss/poms/grid/index.ts:119
117 | .getByTestId("looker")
118 | .count();
> 119 | expect(lookersCount).toBe(n);
| ^
120 | }
121 |
122 | async isNthSampleSelected(n: number) {
at GridAsserter.isLookerCountEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:119:26)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:69:5
|
[chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups:
e2e-pw/src/oss/poms/grid/index.ts#L119
2) [chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(received).toBe(expected) // Object.is equality
Expected: 8
Received: 5
at oss/poms/grid/index.ts:119
117 | .getByTestId("looker")
118 | .count();
> 119 | expect(lookersCount).toBe(n);
| ^
120 | }
121 |
122 | async isNthSampleSelected(n: number) {
at GridAsserter.isLookerCountEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:119:26)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:69:5
|
[chromium] › src/oss/specs/color-scheme/color-scheme.spec.ts:83:3 › color scheme basic functionality with quickstart › update color by value mode:
e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts#L120
3) [chromium] › src/oss/specs/color-scheme/color-scheme.spec.ts:83:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
Error: expect(received).toContain(expected) // indexOf
Expected substring: "rgb(154, 205, 50)"
Received string: "margin: 1.4px; background-color: rgb(0, 102, 255);"
118 |
119 | // verify validation tag has yellow green as background color
> 120 | expect(await tagBubble.getAttribute("style")).toContain(
| ^
121 | "rgb(154, 205, 50)"
122 | );
123 |
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/color-scheme/color-scheme.spec.ts:120:51
|
[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts:55:3 › quickstart-groups › should have four lookers with 'left' as default slice:
e2e-pw/src/oss/poms/grid/index.ts#L119
4) [chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts:55:3 › quickstart-groups › should have four lookers with 'left' as default slice
Error: expect(received).toBe(expected) // Object.is equality
Expected: 4
Received: 8
at oss/poms/grid/index.ts:119
117 | .getByTestId("looker")
118 | .count();
> 119 | expect(lookersCount).toBe(n);
| ^
120 | }
121 |
122 | async isNthSampleSelected(n: number) {
at GridAsserter.isLookerCountEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:119:26)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart-groups.spec.ts:59:5
|
all-tests
Process completed with exit code 1.
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L39
'onLoadError' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L41
'pending' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L53
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L126
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 1.6m
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 40.9s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts took 27.8s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/selection.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/selection.spec.ts took 27.3s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts took 24.0s
|
🎭 Playwright Run Summary
2 failed
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
[chromium] › src/oss/specs/smoke-tests/quickstart-groups-dynamic.spec.ts:67:3 › quickstart-groups › dynamic groups
5 flaky
[chromium] › src/oss/specs/color-scheme/color-scheme.spec.ts:83:3 › color scheme basic functionality with quickstart › update color by value mode, use tag as colorByAttribute
[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts:55:3 › quickstart-groups › should have four lookers with 'left' as default slice
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ────────────
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails
2 skipped
3 did not run
90 passed (12.6m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
20.3 MB |
|
playwright-report
|
117 MB |
|