Grid caching feedback #7540
pr.yml
on: pull_request
modified-files
27s
teams
0s
Matrix: test / test-python
build
/
changes
26s
build
/
build
3m 57s
e2e
/
test-e2e
15m 34s
lint
/
eslint
2m 44s
test
/
test-app
3m 7s
all-tests
0s
Annotations
6 errors, 24 warnings, and 1 notice
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Error: expect(locator).toHaveScreenshot(expected)
2591 pixels (ratio 0.02 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 2591 pixels (ratio 0.02 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 2591 pixels (ratio 0.02 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveScreenshot(expected)
2591 pixels (ratio 0.02 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry1/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry1/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 2591 pixels (ratio 0.02 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 2591 pixels (ratio 0.02 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveScreenshot(expected)
2591 pixels (ratio 0.02 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry2/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry2/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 2591 pixels (ratio 0.02 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 2591 pixels (ratio 0.02 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid:
e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts#L61
1) [chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveScreenshot(expected)
2591 pixels (ratio 0.02 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts-snapshots/select-bottle-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry3/select-bottle-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-sidebar-sidebar--d3b06-select-a-label-filter-works-chromium-retry3/select-bottle-diff.png
Call log:
- expect.toHaveScreenshot(select-bottle.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 2591 pixels (ratio 0.02 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_cc4o6_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 2591 pixels (ratio 0.02 of all image pixels) are different.
59 | await grid.assert.isEntryCountTextEqualTo("1 of 5 samples");
60 |
> 61 | await expect(await grid.getForwardSection()).toHaveScreenshot(
| ^
62 | "select-bottle.png",
63 | { animations: "allow" }
64 | );
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/sidebar/sidebar.spec.ts:61:50
|
e2e / test-e2e
Process completed with exit code 1.
|
all-tests
Process completed with exit code 1.
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L39
'onLoadError' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L41
'pending' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L53
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L126
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip-129e9ad189c9d70b73e77058445db942de0a09f6d57bd7ea8b46bbe81ca2ca91, setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.11.11-pip-129e9ad189c9d70b73e77058445db942de0a09f6d57bd7ea8b46bbe81ca2ca91, setup-python-Linux-x64-24.04-Ubuntu-python-3.11.11-pip
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.9.21-pip-129e9ad189c9d70b73e77058445db942de0a09f6d57bd7ea8b46bbe81ca2ca91, setup-python-Linux-x64-24.04-Ubuntu-python-3.9.21-pip
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip-937994b7e2ea66a8c40b6de1d63eb755de4f5eb04251e29eaa0d9c050e3f1c4c, setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 1.5m
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts took 38.5s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 36.4s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts took 35.0s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts took 23.5s
|
🎭 Playwright Run Summary
1 failed
[chromium] › src/oss/specs/sidebar/sidebar.spec.ts:37:3 › sidebar-filter-visibility › In grid, select a label filter works
2 skipped
3 did not run
96 passed (8.4m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
20.3 MB |
|
playwright-report
|
12 MB |
|