Skip to content

Looker typing cleanup #7541

Looker typing cleanup

Looker typing cleanup #7541

Triggered via pull request March 11, 2025 22:17
Status Failure
Total duration 18m 29s
Billable time 50m
Artifacts 2

pr.yml

on: pull_request
modified-files
24s
modified-files
Matrix: test / test-python
all-tests
0s
all-tests
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 26 warnings, and 1 notice
Unhandled error: app/packages/looker/src/worker/async-labels-rendering-manager.ts#L187
ReferenceError: options is not defined ❯ packages/looker/src/worker/async-labels-rendering-manager.ts:187:9 ❯ AsyncLabelsRenderingManager.enqueueLabelPaintingJob packages/looker/src/worker/async-labels-rendering-manager.ts:175:12 ❯ packages/looker/src/worker/async-labels-rendering-manager.test.ts:104:13 ❯ node_modules/@vitest/runner/dist/index.js:146:14 ❯ node_modules/@vitest/runner/dist/index.js:61:7 ❯ runTest node_modules/@vitest/runner/dist/index.js:960:17 ❯ processTicksAndRejections node:internal/process/task_queues:95:5 ❯ runSuite node_modules/@vitest/runner/dist/index.js:1116:15 ❯ runSuite node_modules/@vitest/runner/dist/index.js:1116:15 This error originated in "packages/looker/src/worker/async-labels-rendering-manager.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running. The latest test that might've caused the error is "packages/looker/src/worker/async-labels-rendering-manager.test.ts". It might mean one of the following: - The error was thrown, while Vitest was running this test. - If the error occurred after the test had been completed, this was the last documented test before it was thrown.
packages/looker/src/worker/async-labels-rendering-manager.test.ts > AsyncLabelsRenderingManager > should enqueue a new job and resolve with merged sample: app/packages/looker/src/worker/async-labels-rendering-manager.ts#L187
ReferenceError: options is not defined ❯ packages/looker/src/worker/async-labels-rendering-manager.ts:187:9 ❯ AsyncLabelsRenderingManager.enqueueLabelPaintingJob packages/looker/src/worker/async-labels-rendering-manager.ts:175:12 ❯ packages/looker/src/worker/async-labels-rendering-manager.test.ts:87:29
packages/looker/src/worker/async-labels-rendering-manager.test.ts > AsyncLabelsRenderingManager > isProcessing() should reflect jobs in the queue: app/packages/looker/src/worker/async-labels-rendering-manager.test.ts#L105
AssertionError: expected false to be true // Object.is equality - Expected + Received - true + false ❯ packages/looker/src/worker/async-labels-rendering-manager.test.ts:105:36
test / test-app
Process completed with exit code 1.
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke: e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts#L1
1) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ─────────── Test timeout of 60000ms exceeded.
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke: e2e-pw/src/shared/event-utils/index.ts#L16
1) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ─────────── Error: page.evaluate: Execution context was destroyed, most likely because of a navigation. at shared/event-utils/index.ts:16 14 | 15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first > 16 | return this.page.evaluate( | ^ 17 | ({ eventName_, exposedFunctionName_ }) => 18 | new Promise<void>((resolve) => { 19 | const cb = (e: CustomEvent) => { at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22) at UrlPom.pageChange (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:40:23) at UrlPom.back (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:47:16) at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts:65:20
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails: e2e-pw/src/oss/poms/saved-views.ts#L158
2) [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails TimeoutError: locator.click: Timeout 2000ms exceeded. Call log: - waiting for getByTestId('saved-views-create-new') - locator resolved to <div data-cy="saved-views-create-new" class="sc-iYBOoK sc-hLtZSE iNAxmh enApcp">…</div> - attempting click action 2 × waiting for element to be visible, enabled and stable - element is not stable - retrying click action - waiting 20ms - waiting for element to be visible, enabled and stable - element is not stable - retrying click action - waiting 100ms - waiting for element to be visible, enabled and stable - element was detached from the DOM, retrying at oss/poms/saved-views.ts:158 156 | await this.openSelect(); 157 | } > 158 | await this.saveNewViewBtn.click({ timeout: 2000 }); | ^ 159 | } 160 | 161 | async savedViewCount(name: string) { at SavedViewsPom.openCreateModal (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/saved-views.ts:158:31) at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts:142:5
all-tests
Process completed with exit code 1.
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L39
'onLoadError' is never reassigned. Use 'const' instead
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L41
'pending' is never reassigned. Use 'const' instead
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L53
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
lint / eslint: app/packages/operators/src/CustomPanel.tsx#L126
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
lint / eslint: app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
test / test-python (ubuntu-latest-m, 3.10)
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip-129e9ad189c9d70b73e77058445db942de0a09f6d57bd7ea8b46bbe81ca2ca91, setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test / test-python (ubuntu-latest-m, 3.9)
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.9.21-pip-129e9ad189c9d70b73e77058445db942de0a09f6d57bd7ea8b46bbe81ca2ca91, setup-python-Linux-x64-24.04-Ubuntu-python-3.9.21-pip
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
test / test-python (ubuntu-latest-m, 3.11)
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.11.11-pip-129e9ad189c9d70b73e77058445db942de0a09f6d57bd7ea8b46bbe81ca2ca91, setup-python-Linux-x64-24.04-Ubuntu-python-3.11.11-pip
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
e2e / test-e2e: e2e-pw/src/oss/specs/regression-tests/media-field.spec.ts#L85
Unexpected use of the `.skip()` annotation
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
e2e / test-e2e
Cache not found for keys: setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip-937994b7e2ea66a8c40b6de1d63eb755de4f5eb04251e29eaa0d9c050e3f1c4c, setup-python-Linux-x64-24.04-Ubuntu-python-3.10.16-pip
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
Slow Test: e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 1.5m
Slow Test: e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts took 38.9s
Slow Test: e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 36.8s
Slow Test: e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts took 24.0s
Slow Test: e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts took 23.4s
🎭 Playwright Run Summary
2 flaky [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ──────────── [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails 2 skipped 98 passed (9.7m)

Artifacts

Produced during runtime
Name Size
dist
20.3 MB
playwright-report
34 MB