-
-
Notifications
You must be signed in to change notification settings - Fork 8
Consolidate environments, support control_branch and summary table #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chambersmp
wants to merge
52
commits into
voxpupuli:master
Choose a base branch
from
chambersmp:feature_prep_pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tfile. * new feature * Fix * Remove test * Check path * Fix read * Fix Puppetfile * Set option to string * Puts * Fix * Fix site.pp * Remove basedir * Removed tmpdir * Fix file remove * Leave repo * Fix * Update Puppetfile * Revert * Git checkout * Add Puppetfile varible * Go back to old method * Reorder events * Removed unused code, delete temp directories.
PR Include Ben's Updates
update comments update comments for git checkout commands purpose
add summary counts using regex add summary counts using regex
change table summary column order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon PR #17.
Issues Resolved:
Fixes #14 - Obtain required node name from the node factset file title (not required if fact[name] exists)
Fixes #16 - Change from
r10k puppetfile installtor10k deploy environmentParameters added:
--no_colordisable terminal colour ascii codes (cleans up log output and cd4pe rendering of stdout)--display_source- display source file and line number for resource--display_detail_add- display attributes for added resourceFeatures/Improvements:
:control_branchref in Puppetfile from the target environment (e.g.developmentwill deploy thedevelopmentbranch of the module instead of the default) thanks tor10k deploy environmenttoandfrombranchfromandtoenvironments are shared across all test threadscoloredtocolored2Documentation:
Version:
Version updated from 0.1.9 to 0.1.10
Thanks @dylanratcliffe