feat: use OpenVox packages when possible #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is now done in voxpupuli-test
We don't use puppetlabs_spec_helper anymore.
idempotent_apply is a puppet_litmus helper
* EN_us.UTF-8 choice breaks install if the locale is not installed on the system, revert default DB locale to C.UTF-8 * Introduce database_locale to change it Kudos @JGodin-C2C @saimonn References puppetlabs/puppetlabs-puppetdb#412 puppetlabs/puppetlabs-puppetdb#421 puppetlabs/puppetlabs-puppetdb#422
ekohl
reviewed
Oct 9, 2025
Comment on lines
+134
to
+135
| $puppetdb_package = inline_epp('openvoxdb<%= $puppetdb::params::puppetdb_major_version %>') | ||
| $terminus_package = inline_epp('openvoxdb-terminus<%= $puppetdb::params::puppetdb_major_version %>') |
There was a problem hiding this comment.
I know this existed before, but isn't this equivalent to:
Suggested change
| $puppetdb_package = inline_epp('openvoxdb<%= $puppetdb::params::puppetdb_major_version %>') | |
| $terminus_package = inline_epp('openvoxdb-terminus<%= $puppetdb::params::puppetdb_major_version %>') | |
| $puppetdb_package = "openvoxdb-${puppetdb::params::puppetdb_major_version}" | |
| $terminus_package = "openvoxdb-terminus-${puppetdb::params::puppetdb_major_version}" |
| match => '^PIDFile.*', | ||
| append_on_no_match => false, | ||
| require => Package['puppetdb'], | ||
| require => Package['openvoxdb'], |
There was a problem hiding this comment.
I think we dropped PIDFile from our services in OpenVoxProject/ezbake@b2de7c7 so I think this whole workaround may no longer be needed.
| port: params[:database_port].to_i, | ||
| encoding: 'UTF8', | ||
| locale: 'en_US.UTF-8' | ||
| locale: 'C.UTF-8' |
There was a problem hiding this comment.
This belongs in the other patch where the locale is changed.
| package { $puppetserver_package: | ||
| ensure => installed, | ||
| } | ||
| # savagely disable dropsonde |
There was a problem hiding this comment.
We don't ship dropsonde in our packages so this shouldn't be needed.
| match => '^PIDFile.*', | ||
| append_on_no_match => false, | ||
| require => Package['puppetserver'], | ||
| require => Package['openvox-server'], |
There was a problem hiding this comment.
I don't think we need this workaround anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.