-
-
Notifications
You must be signed in to change notification settings - Fork 162
Add proper SELinux context and setup appropriate booleans #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Checks fails because CI can't find PostgreSQL 11 packages in the repositories and PuppetDB install fails, this is due to puppetlabs/puppetlabs-puppetdb#379 and puppetlabs/puppetlabs-puppetdb#396 because the failed checks installed puppetlabs-puppetdb v7.14.0 |
|
#388 allowed python 7.x module, this uses a more recent stdlib, so using latest puppetdb module should be possible |
|
@d1nuc0m please rebase against our latest master branch to get rid of the python version commit. |
2e9877f to
b7e6fca
Compare
|
Done, with a bit of tinkering as I also needed to edit metadata.json to add SELinux module. Regarding tests (IRC), what could/should I add? |
9adbe51 to
9e22859
Compare
|
Update: everything should be labelled correctly now |
|
I ran into the same issue, this patch looks correct. I did not have time to test with the fully patched module, but copied the selinux manifest code from here, excluding the booleans already set by the original code. This fixed my puppetboard, thanks! Looks like this needs another rebase as it lowers the allowed python module? |
I should have included my versions. |
* Add puppet/selinux to dependencies
* Set SELinux context for files in ${basedir}/puppetboard, if virtualenv is managed, set context for it too
* Enable httpd_enable_cgi SELinux boolean to allow WSGI execution
Fixes: voxpupuli#336, voxpupuli#365
|
Tests fail due to puppetdb |
Pull Request (PR) description
This should fix issues with SELinux and allow usage in enforcing mode. It works, but as I am not a SELinux expert, permissions for puppetboard and venv files should be reviewed to check if something is missing/permissions should be more restrictive.
Another issue is best practice for certificate path in single node mode - with SELinux enforcing mode Puppetboard can't read files with context
puppet_etc_t(and it should be like this) . In my environment I fixed with this snippetBut probably it is not the best solution, so where should certificates go?
/etc/puppetboard/ssl?This Pull Request (PR) fixes the following issues
Fixes #336
Fixes #365