feat: add ldap user/dn/attribute/filter #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1nuc0m
force-pushed
the
ldap-require
branch
from
afa3bfe to
4996734
Compare
bastelfreak
reviewed
Nov 26, 2024
manifests/apache/conf.pp
Outdated
Comment on lines
39
to
42
| Optional[String] $ldap_require_user = undef, | ||
| Optional[String] $ldap_require_dn = undef, | ||
| Optional[String] $ldap_require_attribute = undef, | ||
| Optional[String] $ldap_require_filter = undef, |
Member
There was a problem hiding this comment.
Are empty strings allowed here, or should String be replaced with String[1]? Or are there even more strict datatypes we could use?
Contributor
Author
There was a problem hiding this comment.
No, empty strings are not allowed - about more restrictive datatypes I don't think it's possible, it would imply to validate LDAP expressions
d1nuc0m
force-pushed
the
ldap-require
branch
2 times, most recently
from
25c228d to
bf8b2eb
Compare
Contributor
Author
|
Sorry for the force pushes, mistakes with commit signing |
d1nuc0m
force-pushed
the
ldap-require
branch
2 times, most recently
from
9922a90 to
712c9a8
Compare
Contributor
Author
|
Reproduced the test failure on a VM of mine, it looks like the culprit is puppetlabs-puppetdb 8.1.0, see also puppetlabs/puppetlabs-puppetdb/#412 |
Allow use of Require ldap-user/ldap-dn/ldap-attribute/ldap-filter in Apache config. Compatible with pre-existing ldap-group settings.
Unmodified tests pass with puppetdb 8.0.1 module. See its issue 412 for probable cause.
d1nuc0m
force-pushed
the
ldap-require
branch
from
505042b to
31b65d0
Compare
Contributor
Author
|
@bastelfreak it works, the fix might also allow to unlock modulesync related issues such as #413 |
Member
|
thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow use of
Require ldap-user/ldap-dn/ldap-attribute/ldap-filterin Apache config.Compatible with pre-existing ldap-group settings.
See mod_authnz_ldap docs