Skip to content

Conversation

@Abdullah-03
Copy link
Contributor

Add appendElement option to WSSecurity, WSSecurityCert, and WSSecurityCertWithToken. When provided with an xml as a string it adds that to the end of the wsse header.

  • Introduced appendElement property in IWSSecurityOptions and IWSSecurityCertOptions interfaces.
  • Updated WSSecurity, WSSecurityCert, and WSSecurityCertWithToken classes to handle the new property.
  • Enhanced Readme.md to document the new feature.
  • Added tests to verify the functionality of appending custom XML elements.

@Abdullah-03
Copy link
Contributor Author

#1341

@w666
Copy link
Collaborator

w666 commented Sep 28, 2025

Seems like build is broken

@w666
Copy link
Collaborator

w666 commented Sep 28, 2025

Also, project was recently converted to use prettier, there are new npm scripts npm run format and npm run format:check if you are not using prettier plugin in your IDE.

@Abdullah-03
Copy link
Contributor Author

Thanks for the feedback @w666. I'll do some refactoring and update the PR in a few days.

@Abdullah-03 Abdullah-03 force-pushed the feature/option-for-custom-xml-in-wsse branch from ac8f8bc to e4235f4 Compare September 29, 2025 18:22
@Abdullah-03 Abdullah-03 requested a review from w666 September 29, 2025 18:23
…lement'.

This allows user to pass a custom xml string that will be added to the Wsse Security element.
@Abdullah-03 Abdullah-03 force-pushed the feature/option-for-custom-xml-in-wsse branch from e4235f4 to f525051 Compare September 29, 2025 18:24
@w666
Copy link
Collaborator

w666 commented Oct 1, 2025

Hi, sorry, I stuck with another issue, will review this one as soon as I can.

@w666
Copy link
Collaborator

w666 commented Oct 6, 2025

@Abdullah-03,

Do you mind if I update it a bit? Or would you prefer some feedback?

@w666
Copy link
Collaborator

w666 commented Oct 6, 2025

I refactored one test as an example. Could you do the sane for the other one. It just makes it much more clear IMO.

@Abdullah-03
Copy link
Contributor Author

Ok, I'll update the remaining tests. I won't squash and force push as I saw an issue where you mentioned that one commit PRs aren't required as you squash in the end anyways. Hopefully that's fine by you.

@w666
Copy link
Collaborator

w666 commented Oct 9, 2025

I made a small format update to one more test, the rest looks good.

@w666 w666 merged commit ed1c2f3 into vpulim:master Oct 9, 2025
1 check passed
@Abdullah-03
Copy link
Contributor Author

Thanks @w666. Apologies for not updating the tests, I have a hectic week at work and was planning to wrap this up on the weekend.

@Abdullah-03 Abdullah-03 deleted the feature/option-for-custom-xml-in-wsse branch October 9, 2025 19:57
@w666
Copy link
Collaborator

w666 commented Oct 9, 2025

No worries at all. I also have couple for PRs to review, then will build a new release, so you should get your changes in a week or two.

@smokhov
Copy link
Contributor

smokhov commented Oct 10, 2025

@w666 -- this PR closes #1341 -- no need to keep it open anymore.

@w666
Copy link
Collaborator

w666 commented Oct 24, 2025

1.6.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants