-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Introduces a new 'addElement' option to WSSE Security to add custom xml to <wsse> header #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces a new 'addElement' option to WSSE Security to add custom xml to <wsse> header #1362
Conversation
|
Seems like build is broken |
|
Also, project was recently converted to use prettier, there are new npm scripts |
|
Thanks for the feedback @w666. I'll do some refactoring and update the PR in a few days. |
ac8f8bc to
e4235f4
Compare
…lement'. This allows user to pass a custom xml string that will be added to the Wsse Security element.
e4235f4 to
f525051
Compare
|
Hi, sorry, I stuck with another issue, will review this one as soon as I can. |
|
Do you mind if I update it a bit? Or would you prefer some feedback? |
|
I refactored one test as an example. Could you do the sane for the other one. It just makes it much more clear IMO. |
|
Ok, I'll update the remaining tests. I won't squash and force push as I saw an issue where you mentioned that one commit PRs aren't required as you squash in the end anyways. Hopefully that's fine by you. |
|
I made a small format update to one more test, the rest looks good. |
|
Thanks @w666. Apologies for not updating the tests, I have a hectic week at work and was planning to wrap this up on the weekend. |
|
No worries at all. I also have couple for PRs to review, then will build a new release, so you should get your changes in a week or two. |
|
1.6.0 has been released |
Add appendElement option to WSSecurity, WSSecurityCert, and WSSecurityCertWithToken. When provided with an xml as a string it adds that to the end of the wsse header.
appendElementproperty in IWSSecurityOptions and IWSSecurityCertOptions interfaces.