#451 Implement UPSEQ

[martinberlin]

Implements a solution for #451

[jonasschnelli]

Tested with the 10.3" Carta1300 display ED103MC1.
I had to comment out epd_lcd_deinit(); in epd_board_v7_103.c to get it compiled.

Worked wonderful! Nice investigation! ❤️

Needs to fixed before merging:

• epd_lcd_deinit compile issue
• EpdDisplayType need to be turned into bitmap flags to allow combination.

[martinberlin]

@jonasschnelli EpdDisplayType need to be turned into bitmap flags to allow combination. that one is fixed!

the other one I still need to research why it triggers.

@vroland please take a look at this too will add you as a reviewer when done

[martinberlin]

@jonasschnelli if you can please do a fullclean, pull this branch again, and build.
Now all clang corrections and the ones you mentioned should be fixed.

[vroland]

Hey, nice work on finding this out! I'm wondering though, why implement it as a new board type? Does it actually require different hardware? Since it may also be useful to enable with normal v7.

[vroland]

Did you check if that power-on sequence impairs any of the other displays? Since it's mentioned in the docs, maybe it should just be the default?

[martinberlin]

Actually it does work with all the others I tested and it can of course work with v7.
But it requires an additional wait time that I though it does not make sense to do it with all, since it’s only required with the new Eink Carta displays like the ED103MC1.

I’m working in a v7_103 PCB that is still not ready to become open source but soon I will send you a new board so you can try it out. In this version the 40 pin FPC comes already mirrored and supporting the modern 16 bit displays from Eink.Thanks for your review!

[vroland]

Ok, then that sounds like it makes sense to have that routine for all the boards with a TPS65185 and factor it out into a common function that checks fo rthe DISPLAY_UPSEQ_MC2 display flag and then sets up the power up sequence if set.

[martinberlin]

Great then I can refactor this and do it for v6, v7. Although v6 didn’t had 16 bit display support maybe there will be some 8 bit panels requiring this up sequence.
Good idea.

[martinberlin]

Updated. Thanks for your review @vroland
Grays are definitely not perfect but the contrast is better than the older model