SPKS Redis: Add extra haproxy config for metrics backends #543
Conversation
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
added
enhancement
TheBigLee
requested review from
a team,
Kidswiss,
mdnix,
mikeshootzz and
zugao
and removed request for
a team
|
| return runtime.NewFatalResult(fmt.Errorf("cannot parse release values from desired release: %w", err)) | ||
| } | ||
|
|
||
| haproxyExtraConfig := fmt.Sprintf(` |
There was a problem hiding this comment.
Couldn't we just do this with a string format PnT patch? https://docs.crossplane.io/latest/guides/function-patch-and-transform/#string-format
There was a problem hiding this comment.
Yes but that would result in a huge unreadable patch. Would you prefer doing it with pnt patch?
There was a problem hiding this comment.
There was a problem hiding this comment.
I thought we decided on that, we use comp-functions for SPKS only when necessary, we keep PnT as base as it used to be!
Update: One thing that I am investigating with our comp function architecture is to get out all the code that we can be configured either with project syn or another configuration manager such as KCL. So this approach here might be true for our appcat comp-functions as well.
There was a problem hiding this comment.
Ok. Thanks for the input. I'll close this PR as I've integrated this logic directly into PnT.
Summary
Checklist
/mergecomment.Component PR: vshn/component-appcat#1007