Skip to content

Conversation

@rodorgas
Copy link
Contributor

@rodorgas rodorgas commented Oct 7, 2025

What problem is this solving?

We're changing the encoded event parameters from adId to eventParameters, since it's not the ad ID. The data attribute is still using the data-van-aid since that's what the Activity Flow use to track events (to be changed in future).

This is backwards compatible as it keeps using the adId as fallback to the eventParameters parameter.

It also removes many data properties that are not being used anymore, since the data-van-aid is the only one considered by Activity Flow currentyl

How to test it?

In this workspace, https://leal--biggy.myvtex.com/ search for the term "camisa".

Screenshots or example usage:

image

Related to / Depends on

vtex-apps/store#605

vtex-apps/search-result#711

@rodorgas rodorgas requested a review from MatheusLealv October 7, 2025 15:25
@rodorgas rodorgas requested review from a team as code owners October 7, 2025 15:25
@rodorgas rodorgas requested review from RodrigoTadeuF, gabpaladino and vsseixaso and removed request for a team October 7, 2025 15:25
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 7, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 7, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against f078208

Copy link
Contributor

@MatheusLealv MatheusLealv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatheusLealv MatheusLealv force-pushed the feat/allow-new-ad-param branch from 51630eb to d6313bc Compare October 15, 2025 14:21
@vsseixaso vsseixaso merged commit 8ed0ba2 into master Nov 5, 2025
6 of 9 checks passed
@vsseixaso vsseixaso deleted the feat/allow-new-ad-param branch November 5, 2025 17:27
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 5, 2025

Your PR has been merged! App is being published. 🚀
Version 2.90.10 → 2.91.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants