-
Notifications
You must be signed in to change notification settings - Fork 55
feat: use the new ad event parameter #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
MatheusLealv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
51630eb to
d6313bc
Compare
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
We're changing the encoded event parameters from
adIdtoeventParameters, since it's not the ad ID. The data attribute is still using the data-van-aid since that's what the Activity Flow use to track events (to be changed in future).This is backwards compatible as it keeps using the
adIdas fallback to theeventParametersparameter.It also removes many data properties that are not being used anymore, since the
data-van-aidis the only one considered by Activity Flow currentylHow to test it?
In this workspace, https://leal--biggy.myvtex.com/ search for the term "camisa".
Screenshots or example usage:
Related to / Depends on
vtex-apps/store#605
vtex-apps/search-result#711