Handle logical expressions when getting attribute values #1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that logical expressions are not being resolved when getting attribute values, and thus simple bindings that should not raise a failed rule are raising, example:
This should not fail the rule because if disabled is false then it actually has tabindex properly, but it currently fails with the "element should be focusable" rule.
The reason behind this is the fact that the own expression is being returned on all cases except for the Literal, that actually returns the value of the attribute.
I understand the TODO that was put on the return of the expression on those cases and I think that handling the LogicalExpression as I did on my PR might be a good addition to at least solve this simple case, even though we definitely have more cases that would require to be handled as the comment suggests.