Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output as controlType for label-has-for rule #1209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

153957
Copy link

@153957 153957 commented Sep 4, 2024

Output element is already in list of controlComponents for form-control-has-label rule. Sort list of controlTypes to be same as in form-control-has-label rule.

This is necessary because form-control-has-label complains that output should have a label:

<output />

error Each form element must have a programmatically associated label element vuejs-accessibility/form-control-has-label

But if you do it complains about the label not being associated with a control:

<label for="out">
  <output id="out" />
</label>

error Form label must have an associated control vuejs-accessibility/label-has-for

Changing the output to progress removes the error, because it is already supported:

<label for="out">
  <progress id="out" />
</label>

Output element is already in list of controlComponents for form-control-has-label rule.
Sort list of controlTypes to be same as in form-control-has-label rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant