Skip to content
This repository has been archived by the owner on Oct 8, 2022. It is now read-only.

Feat/pwa support #95

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Feat/pwa support #95

merged 4 commits into from
Jun 17, 2020

Conversation

iamonuwa
Copy link
Contributor

@iamonuwa iamonuwa commented Jun 7, 2020

@yangwao yangwao self-requested a review June 8, 2020 11:33
Copy link
Member

@yangwao yangwao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep sidebar, a user could be confused what or where page is at, just saying it's offline

dashboard/src/App.vue Show resolved Hide resolved
@yangwao yangwao requested a review from vikiival June 8, 2020 11:38
@vikiival
Copy link
Member

vikiival commented Jun 8, 2020

offline

Hello, I experience trouble with connecting.

Using newest Chrome.

@iamonuwa
Copy link
Contributor Author

Thanks for the review. Fixing this immediately

@iamonuwa
Copy link
Contributor Author

offline

Hello, I experience trouble with connecting.

Using newest Chrome.

I'm unable to reproduce this error on incognito chrome browser

@iamonuwa
Copy link
Contributor Author

@yangwao made the requested change.

@yangwao
Copy link
Member

yangwao commented Jun 17, 2020

Can you please make PR against develop?
I'm happy to merge it, thank you.

@iamonuwa iamonuwa changed the base branch from master to develop June 17, 2020 12:10
@yangwao yangwao merged commit 0197cd3 into vue-polkadot:develop Jun 17, 2020
@iamonuwa
Copy link
Contributor Author

@yangwao done. I can work on more issues for you if you don't mind. I'll get in PRs faster now more than this.

This is a cool feature #71. I did one for burner wallet https://github.com/austintgriffith/burner-wallet-electron.
And many more. You can DM me on twitter @iamonuwa if you want

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressive Web App friendly KodaDot
3 participants