-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): should wrap the top level setup refs with ShallowReactive
#12272
Open
KazariEX
wants to merge
7
commits into
vuejs:main
Choose a base branch
from
KazariEX:fix/distribute-ref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
KazariEX
changed the title
fix(types): should wrap the original type with
fix(types): should wrap the original type with Oct 27, 2024
Reactive
in DistributeRef
UnwrapNestedRefs
in DistributeRef
KazariEX
changed the title
fix(types): should wrap the original type with
fix(types): should wrap the top level setup refs with Oct 30, 2024
UnwrapNestedRefs
in DistributeRef
ShallowReactive
in DistributeRef
KazariEX
changed the title
fix(types): should wrap the top level setup refs with
fix(types): should wrap the top level setup refs with Oct 30, 2024
ShallowReactive
in DistributeRef
ShallowReactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-fix #12095
Expose
IsShallowReactive
to enable type determination in language tools.In non-strict mode,
undefined extends ShallowRef<infer V, unknown>
will be inferred as true, causingUnwrapRef<undefined>
to be inferred asunknown
. Fix it here by the way.