Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): handle multiple patch with boolean style value #12372

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

linzhe141
Copy link
Contributor

close #12368

Copy link

github-actions bot commented Nov 12, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+23 B) 38 kB (+10 B) 34.2 kB (+17 B)
vue.global.prod.js 159 kB (+23 B) 57.9 kB (+8 B) 51.5 kB (+49 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB (+23 B) 18.3 kB (+9 B) 16.7 kB (+9 B)
createApp 55 kB (+23 B) 21.3 kB (+10 B) 19.5 kB (+58 B)
createSSRApp 59 kB (+23 B) 23 kB (+6 B) 20.9 kB (-68 B)
defineCustomElement 59.8 kB (+25 B) 22.9 kB (+13 B) 20.8 kB (+3 B)
overall 68.7 kB (+23 B) 26.4 kB (+8 B) 23.9 kB (-63 B)

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12372

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12372

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12372

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12372

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12372

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12372

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12372

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12372

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12372

vue

pnpm add https://pkg.pr.new/vue@12372

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12372

commit: 7a91330

@edison1105
Copy link
Member

edison1105 commented Nov 13, 2024

CSS property values do not support boolean types. Whether true or false, the value should be set to an empty string.
see Playground with this PR
see https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Values_and_Units

@linzhe141 linzhe141 changed the title fix(runtime-dom): handle multiple patch with falsy style value fix(runtime-dom): handle multiple patch with boolean style value Nov 13, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style binding is wrong when the property evaluates to false and using nextTick()
2 participants